Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect opacity behaviour for <Text> component on iOS #24435

Closed
wants to merge 1 commit into from
Closed

Fixed incorrect opacity behaviour for <Text> component on iOS #24435

wants to merge 1 commit into from

Conversation

shergin
Copy link
Contributor

@shergin shergin commented Apr 13, 2019

Summary

This PR fixes #24229.
Seems currently opacity props for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text.

Changelog

[CATEGORY] [TYPE] - Fixed double applying opacity prop for Text

Test Plan

See #24229 for more details.

@shergin
Update RCTTextShadowView.m
2915e5c 
Fixed incorrect opacity behaviour for <Text> component on iOS
@shergin shergin requested a review from ericlewis April 13, 2019 04:26
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Partner labels Apr 13, 2019
@pull-bot
Copy link

Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 2915e5c

@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Apr 13, 2019
@friederbluemle friederbluemle mentioned this pull request Apr 13, 2019
Closed
cpojer
cpojer approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @shergin! Thank you so much for sending a pull request. I guess we can merge it but next time please include a test plan :P

facebook-github-bot
facebook-github-bot approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @shergin in d99e657.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 15, 2019
grabbou pushed a commit that referenced this pull request May 6, 2019
@shergin @grabbou
Fixed incorrect opacity behaviour for <Text> component on iOS (#24435)
f71357a 
Summary:
This PR fixes #24229.
Seems currently `opacity` props for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text.

[CATEGORY] [TYPE] - Fixed double applying opacity prop for Text
Pull Request resolved: #24435

Differential Revision: D14932795

Pulled By: cpojer

fbshipit-source-id: f9280fc75f788424cb5f1e42d2e79efdb354d645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@cpojer cpojer cpojer approved these changes

@ericlewis ericlewis Awaiting requested review from ericlewis

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: Text Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Opacity prop of Text applies double times.
5 participants
@shergin @pull-bot @react-native-bot @cpojer @facebook-github-bot